Skip to content

Update setup.py#25893

Merged
ydshieh merged 1 commit intomainfrom
update_setup
Aug 31, 2023
Merged

Update setup.py#25893
ydshieh merged 1 commit intomainfrom
update_setup

Conversation

@ydshieh
Copy link
Copy Markdown
Collaborator

@ydshieh ydshieh commented Aug 31, 2023

What does this PR do?

The breakup in #24080 wasn't completely successfully 😭

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Aug 31, 2023

The documentation is not available anymore as the PR was closed or merged.

@ydshieh ydshieh requested a review from amyeroberts August 31, 2023 14:23
@ydshieh
Copy link
Copy Markdown
Collaborator Author

ydshieh commented Aug 31, 2023

I think the failing tests are fixed on main right?

Copy link
Copy Markdown
Contributor

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

Yep - failing tests were on main. @ArthurZucker fixed in #25890

@ydshieh ydshieh merged commit 3fb1535 into main Aug 31, 2023
@ydshieh ydshieh deleted the update_setup branch August 31, 2023 16:54
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
update

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants