[FIX] resize_token_embeddings#26102
Merged
ArthurZucker merged 4 commits intohuggingface:mainfrom Sep 19, 2023
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks for the catch! Could you add a test? 😉
Contributor
Author
|
I'm not so familiar with the transformers repo -- where should a test for this code go? |
Collaborator
|
SHould be part of this tests |
Contributor
Author
|
@ArthurZucker please confirm this test works, I couldn't run it myself since |
Collaborator
|
Sure, I'll test this, can you run |
ArthurZucker
approved these changes
Sep 15, 2023
Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
Contributor
Author
|
@ArthurZucker Ready for merge |
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
* fix roundup command * add test for resize_token_embeddings * Update tests/test_modeling_common.py Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com> * style --------- Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When
resize_token_embeddings(new_num_tokens, pad_to_multiple)is called withnew_num_tokensa multiple ofpad_to_multiple, the model should be resized tonew_num_tokens. Due to a math error, it is instead resized tonew_num_tokens+pad_to_multiple. This PR fixes that bug.@ArthurZucker #25088