Fix RoPE config validation for FalconConfig + various config typos#26929
Merged
gante merged 5 commits intohuggingface:mainfrom Oct 24, 2023
Merged
Fix RoPE config validation for FalconConfig + various config typos#26929gante merged 5 commits intohuggingface:mainfrom
gante merged 5 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
5 tasks
gante
approved these changes
Oct 24, 2023
Contributor
gante
left a comment
There was a problem hiding this comment.
Thank you for fixing my sloppy english :D
ArthurZucker
approved these changes
Oct 24, 2023
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks for the nits
i4never
pushed a commit
to i4never/transformers
that referenced
this pull request
Oct 25, 2023
…uggingface#26929) * Resolve incorrect ValueError in RoPE config for Falcon * Add broken codeblock tag in Falcon Config * Fix typo: an float -> a float * Implement copy functionality for Fuyu and Persimmon for RoPE scaling validation * Make style
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
…uggingface#26929) * Resolve incorrect ValueError in RoPE config for Falcon * Add broken codeblock tag in Falcon Config * Fix typo: an float -> a float * Implement copy functionality for Fuyu and Persimmon for RoPE scaling validation * Make style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
One change that fixes a bug:
config = FalconConfig(alibi=False, rope_scaling={"type": "linear", "factor": 2.0})would fail. (1fbd699)And three changes that fix typos/improve maintainability etc.
I can split this up into two smaller PRs if preferred - just let me know.
Details
Fix RoPE config validation
Running this on main produces:
Which is obviously nonsensical. This is caused by
if self.rotary: raise ValueErrorwhereself.rotaryis justnot self.alibi. So, this ValueError is thrown when alibi isFalse, not when it isTrue.The other 3 changes speak for themselves.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
No new tests - I can add one for the first bug fix if preferred.
Who can review?
@gante