Skip to content

Reproducible checkpoint for npu#27208

Merged
amyeroberts merged 3 commits intohuggingface:mainfrom
ji-huazhong:reproducible_chpt
Nov 2, 2023
Merged

Reproducible checkpoint for npu#27208
amyeroberts merged 3 commits intohuggingface:mainfrom
ji-huazhong:reproducible_chpt

Conversation

@ji-huazhong
Copy link
Copy Markdown
Contributor

@ji-huazhong ji-huazhong commented Nov 1, 2023

What does this PR do?

Save npu's RNG states when saving a checkpoint and set after all the data skip phase when resuming training.
Links to #11582

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

cc @muellerzr

Copy link
Copy Markdown
Contributor

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Copy Markdown
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ji-huazhong
Copy link
Copy Markdown
Contributor Author

@amyeroberts Good day, this PR is ready to be merged :-)

@amyeroberts amyeroberts merged commit c52e429 into huggingface:main Nov 2, 2023
@ji-huazhong ji-huazhong deleted the reproducible_chpt branch November 2, 2023 10:37
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
* save NPU's RNG states when saving a checkpoint and set after all the
data skip phase when resuming training.

* re-trigger ci

* re-trigger ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants