Fix tokenizer export for LLamaTokenizerFast#27222
Merged
LysandreJik merged 2 commits intohuggingface:mainfrom Nov 6, 2023
Merged
Fix tokenizer export for LLamaTokenizerFast#27222LysandreJik merged 2 commits intohuggingface:mainfrom
LysandreJik merged 2 commits intohuggingface:mainfrom
Conversation
Contributor
|
@mayank31398 Could you add the same fix to code llama's fast tokenizer? |
Contributor
Author
|
done @amyeroberts |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Contributor
Author
|
@amyeroberts can you merge this? |
ArthurZucker
approved these changes
Nov 6, 2023
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Looks good to me, thanks 😉
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
* fix tokenizer * fix tokenizer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, LLamaTokenizerFast is not exporting
add_bos_tokenandadd_eos_token. This will fix this issue.Fixes # (issue)
#23833
#23855 (comment)
this is not saving add_eos_token and add_bos_token.
@sgugger @ArthurZucker Can you guys take a look at this?
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?