Conversation
ydshieh
commented
Nov 28, 2023
| with: | ||
| gpu_flavor: mi250 | ||
| secrets: inherit | ||
| run_scheduled_amd_ci: |
Collaborator
Author
There was a problem hiding this comment.
trigger the 2 new workflow file mi210-caller and mi250-caller via workflow run event. They will run as 2 independent workflow runs.
ydshieh
commented
Nov 28, 2023
| CI_SLACK_REPORT_CHANNEL_ID: ${{ secrets.CI_SLACK_CHANNEL_ID_DAILY_AMD }} | ||
| ACCESS_REPO_INFO_TOKEN: ${{ secrets.ACCESS_REPO_INFO_TOKEN }} | ||
| CI_EVENT: Scheduled CI (AMD) | ||
| CI_EVENT: Scheduled CI (AMD) - ${{ inputs.gpu_flavor }} |
Collaborator
Author
There was a problem hiding this comment.
Just a tiny fix so we can see
Results of the Scheduled CI (AMD) - mi250 tests.
instead of
Results of the Scheduled CI (AMD) tests.
on the slack
ydshieh
commented
Nov 28, 2023
Comment on lines
+129
to
+131
| self.n_additional_single_gpu_failures = 0 | ||
| self.n_additional_multi_gpu_failures = 0 | ||
| self.n_additional_unknown_gpu_failures = 0 |
Collaborator
Author
There was a problem hiding this comment.
For AMD push CI, additional_results is empty {} . And dicts_to_sum is not working with this case (failed in functools.reduce)
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
ydshieh
requested review from
LysandreJik
and removed request for
LysandreJik
This was referenced Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
So far, the AMD scheduled CI is run as a single workflow with
mi210andmi250both in it (each has ~500 jobs): see hereThis causes 2 issues:
This page is taking too long to load.)mi210andmi250are mixed (overwritten by each other), so the report might be inaccurate.This PR restructure AMD scheduled CI to make
mi210andmi250run in 2 workflow run, so avoid the above 2 issues.