Assitant model may on a different device#27995
Merged
ArthurZucker merged 4 commits intohuggingface:mainfrom Jan 11, 2024
Merged
Assitant model may on a different device#27995ArthurZucker merged 4 commits intohuggingface:mainfrom
ArthurZucker merged 4 commits intohuggingface:mainfrom
Conversation
Contributor
Author
|
Hi @gante @amyeroberts . Would you please help me to review it? Thx! |
gante
approved these changes
Jan 10, 2024
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
LGTM, thank you for the fix 💛
ArthurZucker
approved these changes
Jan 11, 2024
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks, would be nice to have a reproducer to add as a test but good to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @gante . Would you please have a look at this PR. The motivation is that I try to put assistant model and self model in different cuda device, or put assistant model on CPU. This PR should enable assistant model on a different device.
I have tested it on both decoder-only model and encoder-decoder model. Could you please help me to review it? Thanks!