Skip failing test_save_load_low_cpu_mem_usage tests#29110
Skip failing test_save_load_low_cpu_mem_usage tests#29110amyeroberts wants to merge 1 commit intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
left a comment
There was a problem hiding this comment.
I'm actually in favor of reverting the PR to have a single one that tests all of this and not include it in the release as per the review I made on the open PR!
|
I also in favor of reverting the original PR #28948 - if that PR is not something urgent to be in (The test fetcher is indeed not ideal, but there is a trade-off and we can decide how to improve it.) However, I am OK for this PR to be merged if we decide so - the job is already done (the time is spent) anyway. |
ydshieh
left a comment
There was a problem hiding this comment.
Thank you for taking the time Amy!
|
@ydshieh @ArthurZucker I agree, let's revert for now. The main reason is I don't trust the testing suite at the moment. @hackyon opened another, more complete PR to address the failing models #29118 which believe were retrieved from explicitly testing However, because we're just about to release, let's err on the side of caution. |
What does this PR do?
Related to #29043 and #28948
Fixes more failing model tests on main which weren't picked up by the test fetcher cc @ydshieh cc @ArthurZucker