Skip to content

Mistral qna#29168

Closed
sriram-1 wants to merge 8 commits intohuggingface:mainfrom
sriram-1:MistralQnA
Closed

Mistral qna#29168
sriram-1 wants to merge 8 commits intohuggingface:mainfrom
sriram-1:MistralQnA

Conversation

@sriram-1
Copy link
Copy Markdown

What does this PR do?

Added a MistralForQuestionAnswering class to the modeling_mistral.py so Mistral models have AutoModelForQuestionAnswering support.

Fixes #28908

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ArthurZucker
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Copy Markdown
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As I usually say, let's first open a feature request for this, and if the community is eager to have it we'll merge! 🤗 there are not checkpoints available so not really usable as is

@sriram-1
Copy link
Copy Markdown
Author

@ArthurZucker #28908 already feature request is tagged.

@ArthurZucker
Copy link
Copy Markdown
Collaborator

Then let's wait until:

  • either community pushes for this
  • there are good checkpoints for this model and task! 🥳

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions Bot closed this Apr 14, 2024
@vasqu vasqu mentioned this pull request Oct 9, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MistralForQuestionAnswering

2 participants