[Llama ROPE] Fix torch export but also slow downs in forward#29198
Merged
ArthurZucker merged 25 commits intomainfrom Feb 28, 2024
Merged
[Llama ROPE] Fix torch export but also slow downs in forward#29198ArthurZucker merged 25 commits intomainfrom
Llama ROPE] Fix torch export but also slow downs in forward#29198ArthurZucker merged 25 commits intomainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
younesbelkada
approved these changes
Feb 22, 2024
Contributor
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
Seems good once the CI passes!
gante
approved these changes
Feb 22, 2024
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
Missing: a test for torch.compile!
Contributor
|
+1 @gante there should be tests for torch.compile / torch.compile with |
4 tasks
Collaborator
Author
|
Yes yes! |
ArthurZucker
changed the title
Llama ROPE] Export but also slow down in forward.Llama ROPE] Fix torch export but also slow downs in forward
ArthurZucker
added a commit
that referenced
this pull request
Feb 28, 2024
* remove control flow * update gptneox * update .... * nits * Actually let's just break. Otherwise we are silently failing which imo is not optimal * version BC * fix tests * fix eager causal * nit * add a test * style * nits * nits * more nits for the test * update and fix * make sure cuda graphs are not skipped * read token is needed for meta llama * update! * fiixup * compile test should be slow * fix thet fix copies * stle 🫠
ArthurZucker
added a commit
that referenced
this pull request
Mar 1, 2024
* remove control flow * update gptneox * update .... * nits * Actually let's just break. Otherwise we are silently failing which imo is not optimal * version BC * fix tests * fix eager causal * nit * add a test * style * nits * nits * more nits for the test * update and fix * make sure cuda graphs are not skipped * read token is needed for meta llama * update! * fiixup * compile test should be slow * fix thet fix copies * stle 🫠
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reverts some of the breaking changes introduce in #29109
The release mentions that we have a breaking change.
This makes it truly BC in the way you access
sin_cachewithout memory / tracing / forward issue.fixes #29173