Use torch.bool instead of torch.int64 for non-persistant causal mask buffer#29241
Merged
fxmarty merged 1 commit intohuggingface:mainfrom Feb 26, 2024
Merged
Use torch.bool instead of torch.int64 for non-persistant causal mask buffer#29241fxmarty merged 1 commit intohuggingface:mainfrom
torch.bool instead of torch.int64 for non-persistant causal mask buffer#29241fxmarty merged 1 commit intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
Can confirm this shrunk my tiny-random-GemmeForCausalLM ONNX export from ~500MB to ~70MB (PR). Ideally, there would be no overhead, but I think this helps a ton for now! |
amyeroberts
approved these changes
Feb 26, 2024
Contributor
amyeroberts
left a comment
There was a problem hiding this comment.
LGTM - thanks for digging into this and fixing!
Happy to merge once slow model tests for gemma and llama are confirmed to be passing.
Contributor
Author
|
@amyeroberts Running on A100, I can confirm that no additional tests are failing with |
4 tasks
ArthurZucker
pushed a commit
that referenced
this pull request
Feb 28, 2024
…ask buffer (#29241) use torch.bool instead of torch.int64
ArthurZucker
pushed a commit
that referenced
this pull request
Mar 1, 2024
…ask buffer (#29241) use torch.bool instead of torch.int64
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
self.register_buffer("causal_mask", torch.triu(causal_mask, diagonal=1), persistent=False)in @ArthurZucker's rewrite of llama & gemma adds a 500 MB overhead when serializing to ONNX/TorchScript IR/PyTorch ExportedProgram (from https://pytorch.org/docs/stable/export.html), formax_position_embeddings=8182.Essentially, these IRs do not support non-persistent buffers. One quick fix is to use torch.bool instead of torch.int64, but bool is still 8-bits in pytorch (pytorch/pytorch#41571) & the overhead is still ~70 MB.
The lowered overhead is acceptable to me, but this won't scale to 10M context length.