Fix max length for BLIP generation#29296
Merged
ArthurZucker merged 10 commits intohuggingface:mainfrom Mar 5, 2024
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
gante
reviewed
Feb 27, 2024
gante
reviewed
Feb 27, 2024
Contributor
|
it also needs a |
Co-authored-by: Joao Gante <joaofranciscocardosogante@gmail.com>
Co-authored-by: Joao Gante <joaofranciscocardosogante@gmail.com>
Contributor
|
@ArthurZucker the failing test is unrelated (safetensors usage test, timeout) and reruning tests doesn't make it green -- would you be able to merge this PR? 🤗 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the previous PR #28994, I did not make changes in multimodal models, which have custom
generateand pass ininput_embeds. This PR fixes it. Currently the only model intransformersfailing in generation from embeds is BLIP2 and its instruct version. I checked other multimodal generation models, everything is fine there.Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@gante