Super tiny fix unused masked_bias#30235
Conversation
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks!
Indeed - it seems self.masked_bias was removed in #17306
As the buffer isn't persistent, removing shouldn't cause any breaking changes or warnings for the users.
|
@fzyzcjy Running |
|
Oops I forgot this... Will do it later when working with #30647 |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
|
@fzyzcjy Any update on this PR? |
|
Sorry I do not have huggingface transformers environment locally and may not worth it to create one for this single-line PR... |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
What does this PR do?
Hi thanks for the library! When learning (thus reading source code) GPT2, it seems that the
masked_biasis not used. I have searched this keyword in the lib and does not find usages as well. Thus I try to make this PR and see whether the removal still makes CI happy.Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.