Closed
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
Thanks for opening @zucchini-nlp and addressing so quickly! This should be fixed on main. I had a PR open to addressed - #30258 - and was waiting for review. Decided to merge to avoid red on main |
Member
Author
|
Ah I see, thanks. I'll close this PR then :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
IDEFICS-2 pull request has added MODEL_FOR_VISION_2_SEQ_MAPPING_NAMES to the preparation of inputs in "test_modeling_common.py". That started causing test failures for composite vision language models, which do not have "seq_length" in their tester. This PR adds "seq_length" in a similar way "batch_size" was added to these models before.
All tests for the changed models are passing locally. Llava and other VLMs do not have a composite structure, so the tests are passing without a fix.