Fix GroundingDINO, DPR after BERT SDPA update#30506
Merged
amyeroberts merged 1 commit intohuggingface:mainfrom Apr 26, 2024
Merged
Fix GroundingDINO, DPR after BERT SDPA update#30506amyeroberts merged 1 commit intohuggingface:mainfrom
amyeroberts merged 1 commit intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
GroundingDINO and DPR models broke after the merging in of #28802 as they use BERT as a backbone / encoder. SDPA is now selected as the attention implementation for BERT by default, but wasn't supported by these models.
For GroundingDINO, we make sure to pass the current model's config implementation when making the model.
For DPR, as the only attention is from BERT, we say it now supports SDPA.
Fixes failing tests on main e.g. this run: https://app.circleci.com/pipelines/github/huggingface/transformers/91014/workflows/dfdf4b73-b123-4c08-bbc4-bb6214737293/jobs/1188921