Fix CI after #30410#30612
Merged
zucchini-nlp merged 3 commits intohuggingface:mainfrom May 2, 2024
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
approved these changes
May 2, 2024
Collaborator
ydshieh
left a comment
ydshieh
left a comment
There was a problem hiding this comment.
Thanks a lot. And LGTM.
Collaborator
|
@zucchini-nlp would you like to try the |
Collaborator
|
Rebase on main to include #30540 (if not yet) Push an empty commit with the message: |
Member
Author
|
Yes, lets see the slow-tests in action 😄 |
Collaborator
(note: the above run is not the Pipeline tests where we found the issue in the first place) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per title, the prev PR forgot to replace Embedding layer in one of the models which caused red CI. This PR fixes it :)
cc @ydshieh