test_custom_4d_attention_mask skip with sliding window attn#30833
Merged
ArthurZucker merged 1 commit intohuggingface:mainfrom May 23, 2024
Merged
test_custom_4d_attention_mask skip with sliding window attn#30833ArthurZucker merged 1 commit intohuggingface:mainfrom
ArthurZucker merged 1 commit intohuggingface:mainfrom
Conversation
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Sounds good, cc @ydshieh will help you 😉
ArthurZucker
approved these changes
May 23, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #30348
tests/models/qwen2/test_modeling_qwen2.py::Qwen2ModelTest::test_custom_4d_attention_maskwas failing because of use of sliding window attention.While this sliding window attention does not preclude use of custom 4D masks, it requires modification of the original
test_custom_4d_attention_mask.Summoning @ArthurZucker @gante to review