Skip to content

get_proposal_pos_embed of deformable_detr support return dtype of proposal #30946

Closed
DonggeunYu wants to merge 4 commits intohuggingface:mainfrom
DonggeunYu:main
Closed

get_proposal_pos_embed of deformable_detr support return dtype of proposal #30946
DonggeunYu wants to merge 4 commits intohuggingface:mainfrom
DonggeunYu:main

Conversation

@DonggeunYu
Copy link
Copy Markdown
Contributor

@DonggeunYu DonggeunYu commented May 22, 2024

What does this PR do?

Currently function get_proposal_pos_embed is fixed with return float32.
Modified to return dtype of proposal.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Copy link
Copy Markdown
Contributor

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

Comment thread src/transformers/models/deformable_detr/modeling_deformable_detr.py Outdated
…tr.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@DonggeunYu
Copy link
Copy Markdown
Contributor Author

The lint problem is with other files.

@amyeroberts
Copy link
Copy Markdown
Contributor

@DonggeunYu Indeed. I've tried re-running, but it doesn't appear to be using the new docker images (which it should). Could you try rebasing on main?

@DonggeunYu
Copy link
Copy Markdown
Contributor Author

@DonggeunYu Indeed. I've tried re-running, but it doesn't appear to be using the new docker images (which it should). Could you try rebasing on main?

@amyeroberts Done.

@DonggeunYu
Copy link
Copy Markdown
Contributor Author

@amyeroberts Please check this PR.

Copy link
Copy Markdown
Contributor

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amyeroberts
Copy link
Copy Markdown
Contributor

@DonggeunYu Yesterday, we deprecated DETA. Could you rebase to include this change on main here? This will resolve the repo consistency check

@DonggeunYu
Copy link
Copy Markdown
Contributor Author

@DonggeunYu Yesterday, we deprecated DETA. Could you rebase to include this change on main here? This will resolve the repo consistency check

@amyeroberts Completed.

@amyeroberts
Copy link
Copy Markdown
Contributor

@DonggeunYu My bad, the # Copied froms are still active. I've opened a PR to #31153 to remove these. Once merged, we can add that in and then we won't need to worry about DETA for this PR. Thanks for your patience!

@DonggeunYu DonggeunYu closed this Jun 3, 2024
@amyeroberts
Copy link
Copy Markdown
Contributor

@DonggeunYu #31153 has been merged in. It would be good to still merge in this PR! I'll reopen. If you still wish to add and work on this, then adding upstream changes from main should fix the failing tests and I can merge. Otherwise fee lfree to close again :)

@amyeroberts amyeroberts reopened this Jun 3, 2024
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@DonggeunYu DonggeunYu closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants