get_proposal_pos_embed of deformable_detr support return dtype of proposal #30946
get_proposal_pos_embed of deformable_detr support return dtype of proposal #30946DonggeunYu wants to merge 4 commits intohuggingface:mainfrom
Conversation
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for adding this!
…tr.py Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
|
The lint problem is with other files. |
|
@DonggeunYu Indeed. I've tried re-running, but it doesn't appear to be using the new docker images (which it should). Could you try rebasing on main? |
@amyeroberts Done. |
|
@amyeroberts Please check this PR. |
|
@DonggeunYu Yesterday, we deprecated DETA. Could you rebase to include this change on main here? This will resolve the repo consistency check |
@amyeroberts Completed. |
|
@DonggeunYu My bad, the # Copied froms are still active. I've opened a PR to #31153 to remove these. Once merged, we can add that in and then we won't need to worry about DETA for this PR. Thanks for your patience! |
|
@DonggeunYu #31153 has been merged in. It would be good to still merge in this PR! I'll reopen. If you still wish to add and work on this, then adding upstream changes from main should fix the failing tests and I can merge. Otherwise fee lfree to close again :) |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
What does this PR do?
Currently function
get_proposal_pos_embedis fixed with return float32.Modified to return dtype of proposal.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?