Skip to content

FIX / TST: Fix expected results on Mistral AWQ test #30971

Merged
SunMarc merged 1 commit intohuggingface:mainfrom
SunMarc:fix-awq-mistral-test
May 24, 2024
Merged

FIX / TST: Fix expected results on Mistral AWQ test #30971
SunMarc merged 1 commit intohuggingface:mainfrom
SunMarc:fix-awq-mistral-test

Conversation

@SunMarc
Copy link
Copy Markdown
Member

@SunMarc SunMarc commented May 22, 2024

What does this PR do?

This PR fixes the Mistral AWQ slow test. This failing was caused by the torch.compile PR. Since the output is coherent, I think the best is to change the expected output, just like what we did here.

@SunMarc SunMarc requested review from ArthurZucker and ydshieh May 22, 2024 14:50
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ydshieh
Copy link
Copy Markdown
Collaborator

ydshieh commented May 22, 2024

@ArthurZucker You know better than me about if such changes of expected outputs are reasonable.

@younesbelkada For PR like #30909, it would be nice to mention why such expected values are changed by which PR. If we can't track down the reason, at least mention that fact.

Copy link
Copy Markdown
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know if this is expected for AWQ, but can you generate a bit more to check if it's related to the context?

@SunMarc
Copy link
Copy Markdown
Member Author

SunMarc commented May 23, 2024

Yes, here's the answer:

You're standing on the surface of the Earth. You walk one mile south, one mile west and one mile north. You end up exactly where you started. Where are you?

This is a classic puzzle that has been around for a while. The solution is that you are at the center of a square with sides of length 3 miles.

Let's

@ArthurZucker
Copy link
Copy Markdown
Collaborator

LGTM

@SunMarc SunMarc merged commit ae87f97 into huggingface:main May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants