FIX / TST: Fix expected results on Mistral AWQ test #30971
Merged
SunMarc merged 1 commit intohuggingface:mainfrom May 24, 2024
Merged
FIX / TST: Fix expected results on Mistral AWQ test #30971SunMarc merged 1 commit intohuggingface:mainfrom
SunMarc merged 1 commit intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
|
@ArthurZucker You know better than me about if such changes of expected outputs are reasonable. @younesbelkada For PR like #30909, it would be nice to mention why such expected values are changed by which PR. If we can't track down the reason, at least mention that fact. |
ArthurZucker
approved these changes
May 23, 2024
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
I don't really know if this is expected for AWQ, but can you generate a bit more to check if it's related to the context?
Member
Author
|
Yes, here's the answer: |
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the Mistral AWQ slow test. This failing was caused by the torch.compile PR. Since the output is coherent, I think the best is to change the expected output, just like what we did here.