Skip tests properly#31308
Merged
amyeroberts merged 5 commits intohuggingface:mainfrom Jun 26, 2024
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
force-pushed
the
add-has-attentions-skip
branch
3 times, most recently
from
17b18bc to
8b91ec8
Compare
amyeroberts
force-pushed
the
add-has-attentions-skip
branch
2 times, most recently
from
5a3df67 to
051d815
Compare
amyeroberts
force-pushed
the
add-has-attentions-skip
branch
from
fee629e to
41976a3
Compare
ydshieh
approved these changes
Jun 26, 2024
Collaborator
ydshieh
left a comment
ydshieh
left a comment
There was a problem hiding this comment.
Wow, big change! Thank you for taking care of the library!
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
thanks for being thourough
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes sure all tests which are skipped are done so with an explicit skip. This helps with test stats, and doesn't make us think some tests are passing when they're actually empty which can be confusing c.f. this comment