Fix Bark logits processors device misplacement#31416
Fix Bark logits processors device misplacement#31416ylacombe merged 1 commit intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Thanks for working on a fix!
I'm a bit confused by this solution - neither SuppressTokensLogitsProcessor nor BarkEosPrioritizerLogitsProcessor take My bad - I was looking at an older commitdevice as an init kwarg
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for fixing!
Tbh, this pattern of passing the device here I think is a bit odd (why do we take a tensor, turn it into a list, then turn it back into a tensor on the device? but that's more of a generate question)
It's not at the moment, we've discussed the reasons why in this thread. It might make sense to revisit this decision once the standard generation method is refactored, WDYT ? |
|
Thank you @ylacombe ! @amyeroberts There is still |
What does this PR do?
Fix some Bark failing tests where the logits processors' tensors were misplaced on CPU!
It was introduced by #29804 but not flagged because of the Bark custom generation!
Slow tests are now all green on a A100!
cc @ydshieh and @amyeroberts