Set seed for M4T retain grad test#31419
Merged
ylacombe merged 1 commit intohuggingface:mainfrom Jun 14, 2024
Merged
Conversation
amyeroberts
reviewed
Jun 14, 2024
Contributor
amyeroberts
left a comment
amyeroberts
left a comment
There was a problem hiding this comment.
🥳 🙌
Thanks for fixing!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
Thanks for the review @amyeroberts ! Let me know when I can merge! |
amyeroberts
approved these changes
Jun 14, 2024
Contributor
amyeroberts
left a comment
amyeroberts
left a comment
There was a problem hiding this comment.
Ah, sorry, I meant to approve. All good to merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The speech encoder attentions of M4T can be None with a non-zero probability when training=True. Instead of skipping the test, this PR fixes the seed so that the first layer is never skipped:
test_retain_grad_hidden_states_attentions.I've ran it multiple times and it passed every time.
cc @amyeroberts
Fixes #28036