Refactor flash attention implementation in transformers#31446
Merged
Conversation
Collaborator
Author
|
cc @fxmarty, @LysandreJik and @OlivierDehaene |
This was referenced Jun 18, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
commented
Jul 9, 2024
Collaborator
Author
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks so much @fxmarty for going to the end of this!
5 tasks
Contributor
|
No more flash attention tests fail here compared to main (on H100). Testing on MI250 for extra safety and good to merge. edit: all good, can be merged |
This was referenced Jul 11, 2024
5 tasks
3 tasks
4 tasks
7 tasks
5 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
EDIT: just refactor for now
Enables us to run transformers model with Ragged Tensors:
One of the goals is also to make it easy for people to re-define the
ExtraKwargstypedict, to build on top of transformers