[QoL] Allow dtype str for torch_dtype arg of from_pretrained#31590
Merged
ArthurZucker merged 3 commits intohuggingface:mainfrom Jun 27, 2024
Merged
[QoL] Allow dtype str for torch_dtype arg of from_pretrained#31590ArthurZucker merged 3 commits intohuggingface:mainfrom
ArthurZucker merged 3 commits intohuggingface:mainfrom
Conversation
5 tasks
amyeroberts
reviewed
Jun 25, 2024
Contributor
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for adding! I think this looks OK, but let's get a second opinion from @ArthurZucker as this touches a core part of the modeling logic.
We should also add tests - probably under test_modeling_utils.py
Contributor
Author
|
@amyeroberts added them |
amyeroberts
approved these changes
Jun 26, 2024
Contributor
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for adding the tests!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is to align with the behavior of
pipelinewhere users can pass strings liketorch_dtype="float32"and it gets recognized astorch.float32. It now also happens for anyPretrainedModel.from_pretrained.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@amyeroberts