Requires for torch.tensor before casting#31755
Merged
LysandreJik merged 1 commit intohuggingface:mainfrom Jul 3, 2024
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
approved these changes
Jul 2, 2024
| import torch | ||
|
|
||
| return x.to(torch.int64) if torch.jit.is_tracing() else int(x) | ||
| return x.to(torch.int64) if torch.jit.is_tracing() and isinstance(x, torch.Tensor) else int(x) |
Collaborator
Author
There was a problem hiding this comment.
do you mean ensuring shift_size is a torch.Tensor when jit tracing in the modeling directly ?
| import torch | ||
|
|
||
| return x.to(torch.float32) if torch.jit.is_tracing() else int(x) | ||
| return x.to(torch.float32) if torch.jit.is_tracing() and isinstance(x, torch.Tensor) else int(x) |
Contributor
There was a problem hiding this comment.
I think since we're explicitly calling torch_float where float was used to be it should be fine, no?
Collaborator
Author
|
@amyeroberts do you think this fix could be included in a patch release ? |
Member
|
@echarlaix I'm happy to include it in a patch release towards the end of the week |
Collaborator
Author
thanks a lot! |
This was referenced Jul 3, 2024
ArthurZucker
pushed a commit
that referenced
this pull request
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ONNX export for swin, swin-donut and clap models
transformers/src/transformers/models/swin/modeling_swin.py
Line 643 in 82486e5
coming from :
introduced in #31311
as
torch_intis expecting atorch.Tensor:transformers/src/transformers/utils/generic.py
Line 765 in 82486e5
also I think we should be able to have here
cc @merveenoyan @xenova