Skip to content

Whisper fix audio out of range#31770

Closed
maxkvbn wants to merge 3 commits intohuggingface:mainfrom
maxkvbn:whisper-fix-audio-out-of-range
Closed

Whisper fix audio out of range#31770
maxkvbn wants to merge 3 commits intohuggingface:mainfrom
maxkvbn:whisper-fix-audio-out-of-range

Conversation

@maxkvbn
Copy link
Copy Markdown

@maxkvbn maxkvbn commented Jul 3, 2024

What does this PR do?

Fixes #31683

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@maxkvbn
Copy link
Copy Markdown
Author

maxkvbn commented Jul 3, 2024

@sanchit-gandhi

@amyeroberts
Copy link
Copy Markdown
Contributor

Gentle ping @sanchit-gandhi @kamilakesbi

@huggingface huggingface deleted a comment from github-actions Bot Aug 27, 2024
@amyeroberts
Copy link
Copy Markdown
Contributor

cc @ylacombe

@ylacombe
Copy link
Copy Markdown
Contributor

ylacombe commented Sep 3, 2024

Hey @maxkvbn, thanks for opening this PR and for #31683!

Do you think you could send the audio that causes your code to fail? The link to download it is no longer working. Or better yet, an end-to-end snippet to reproduce it. If that's okay with you, I'll review your PR once I can reproduce the error!

@ylacombe
Copy link
Copy Markdown
Contributor

Hey @maxkvbn, gentle up!

@maxkvbn
Copy link
Copy Markdown
Author

maxkvbn commented Sep 13, 2024

Hey @ylacombe

I've reuploaded the audio in question: https://fastupload.io/b9ff61358ef5c4b1

@ylacombe
Copy link
Copy Markdown
Contributor

Thanks for the audio @maxkvbn, I was able to reproduce the issue!

I believe the issue happens when using num_beams>1, which gives a small indication on what could have gone wrong. Let me check a bit more

@ylacombe
Copy link
Copy Markdown
Contributor

Hey @maxkvbn, after some deeper investigation, I'm fairly certain the bugs come from the generation itself, and not the tokenization!

I still have to figure out how to actually fix it, but it comes from a recent change in Whisper.generate. I'll ping you once it's fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Whisper - list index out of range with word level timestamps

4 participants