Fix failing test with race condition#32140
Merged
Rocketknight1 merged 5 commits intomainfrom Jul 22, 2024
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
Ready for review @amyeroberts! In case you're worried about the |
amyeroberts
approved these changes
Jul 22, 2024
Contributor
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for handling @Rocketknight1
Collaborator
Thank you. I didn't touch anything about Anyway, I will rework this kind of thing in #32025 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test_push_to_hub_dynamic_processorcallscreate_repowith a fixed repo name, and often throws an error in the CI. I suspect this happens when multiple test runners try to create the repo at the same time.I rewrote the test to use a randomized repo name, which should hopefully avoid these collisions - though I don't know how the dummy user works, so I hope these still get cleaned up!