link for optimizer names#32400
Merged
nbroad1881 merged 2 commits intomainfrom Aug 20, 2024
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
reviewed
Aug 5, 2024
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Cool! Can you run make fixup to fix cis!
SunMarc
approved these changes
Aug 5, 2024
Member
SunMarc
left a comment
SunMarc
left a comment
There was a problem hiding this comment.
Nice ! Thanks for adding @nbroad1881 !
Contributor
Author
|
How is it now? |
Contributor
Author
|
Did I mess up the rebase? |
Contributor
|
@nbroad1881 probably 😓 those are always fun. You can either reset hard or open a PR |
Contributor
|
@nbroad1881 From the commit history, it looks like you pushed after rebase but didn't push force (I know because I've done this myself... ). You should be able to force push again to resolve |
Add a note and link to where the user can find more optimizer names easily because there are many more optimizers than are mentioned in the docstring.
nbroad1881
force-pushed
the
optim-names
branch
from
f93a301 to
8679705
Compare
Contributor
Author
|
Ok I think I fixed it 😅 |
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* link for optimizer names Add a note and link to where the user can find more optimizer names easily because there are many more optimizers than are mentioned in the docstring. * make fixup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a note and link to where the user can find more optimizer names easily because there are many more optimizers than are mentioned in the docstring.
@muellerzr @SunMarc