Skip to content

Fix gemma2 with sdpa? #32403

Closed
ArthurZucker wants to merge 1 commit intomainfrom
fix-gemma2-sdpa
Closed

Fix gemma2 with sdpa? #32403
ArthurZucker wants to merge 1 commit intomainfrom
fix-gemma2-sdpa

Conversation

@ArthurZucker
Copy link
Copy Markdown
Collaborator

@ArthurZucker ArthurZucker commented Aug 3, 2024

What does this PR do?

Fixes #32390

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ArthurZucker ArthurZucker marked this pull request as ready for review August 9, 2024 09:34
@ArthurZucker ArthurZucker changed the title Fix #32390 Fix gemma2 with sdpa? Aug 9, 2024
@ArthurZucker
Copy link
Copy Markdown
Collaborator Author

Closing as #34282 superseeds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gemma 2 returns NaN when using default attn (sdpa) with padding

2 participants