fix: Added missing huggingface_hub installation to workflows#32891
Merged
amyeroberts merged 4 commits intohuggingface:mainfrom Aug 22, 2024
Merged
fix: Added missing huggingface_hub installation to workflows#32891amyeroberts merged 4 commits intohuggingface:mainfrom
huggingface_hub installation to workflows#32891amyeroberts merged 4 commits intohuggingface:mainfrom
Conversation
Collaborator
|
Thank you @Sai-Suraj-27 . We should move to using |
ydshieh
approved these changes
Aug 21, 2024
…to fix_workflows
amyeroberts
approved these changes
Aug 22, 2024
Contributor
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks!
The failing tests should have been resolved with some updates to the CI images. I can't re-trigger the CI runs, as they failed too long ago. @Sai-Suraj-27 could you push an empty commit to try and retrigger a run?
…to fix_workflows
Contributor
Author
Thanks for the review @amyeroberts. Done 👍🏻. All the tests are passing now. |
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
…ngface#32891) Added missing huggingface_hub installation to workflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
utils/notification_service.pyfile requireshuggingface_hubpackage.transformers/utils/notification_service.py
Line 30 in 85345bb
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ydshieh @amyeroberts