fix the parallel number of CI nodes when it is smaller than number of tests#33276
Merged
ArthurZucker merged 22 commits intomainfrom Sep 3, 2024
Merged
fix the parallel number of CI nodes when it is smaller than number of tests#33276ArthurZucker merged 22 commits intomainfrom
ArthurZucker merged 22 commits intomainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
LysandreJik
approved these changes
Sep 3, 2024
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
Thanks! Is it possible to document what's happening here somewhere? (ideally in the inline comments).
This looks like it could rapidly grow into something hard to understand
ArthurZucker
changed the title
ArthurZucker
changed the title
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
… tests (huggingface#33276) * fix the parallel number * this? * keep it simple * woups * nit * style * fix param name * fix * fix dtype * yups * ??? * ?? * this? * ???? * no default flow style * ?? * print config * ???? * there we go! * documentation * update * remove unwanted file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes a bug where the
self.parallelwhich defines the number of nodes to run the tests on circle-ci was bigger than the actual number of tests.This caused the
split testsstep to only give 1 test to 1 node, and all tests to other parallel nodes, thus failing them!This is related to the recent #30674.