Add validate images and text inputs order util for processors and test_processing_utils#33285
Merged
yonigozlan merged 5 commits intohuggingface:mainfrom Sep 4, 2024
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
CI failing because of this #32406 it seems |
amyeroberts
reviewed
Sep 4, 2024
Contributor
There was a problem hiding this comment.
Reminder to remove the int checks in this function
Member
Author
There was a problem hiding this comment.
Oops, should be good now
yonigozlan
force-pushed
the
add-test-processing-utils
branch
from
81c25de to
d7aeafc
Compare
amyeroberts
approved these changes
Sep 4, 2024
Contributor
amyeroberts
left a comment
amyeroberts
left a comment
There was a problem hiding this comment.
Looks great - thanks for adding this!
Comment on lines
+1005
to
+1018
| if isinstance(t, str): | ||
| # Strings are fine | ||
| return True | ||
| elif isinstance(t, (list, tuple)): | ||
| # List are fine as long as they are... | ||
| if len(t) == 0: | ||
| # ... not empty | ||
| return False | ||
| elif isinstance(t[0], str): | ||
| # ... list of strings | ||
| return True | ||
| elif isinstance(t[0], (list, tuple)): | ||
| # ... list of list of strings | ||
| return isinstance(t[0][0], str) |
Contributor
There was a problem hiding this comment.
This can be re-written to be recursive
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
…t_processing_utils (huggingface#33285) * Add validate images and test processing utils * Remove encoded text from possible inputs in tests * Removed encoded inputs as valid in processing_utils * change text input check to be recursive * change text check to all element of lists and not just the first one in recursive checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add validate images and text inputs order util that will be used as a tool to preserve backward compatibility during the transition to uniform kwargs (#31911).
Add corresponding tests in test_processing_utils.py (didn't exist before).
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.