solve device issue in cos and sin in Qwen2's ROPE Embedding#33391
Closed
irislin1006 wants to merge 8 commits intohuggingface:mainfrom
Closed
solve device issue in cos and sin in Qwen2's ROPE Embedding#33391irislin1006 wants to merge 8 commits intohuggingface:mainfrom
irislin1006 wants to merge 8 commits intohuggingface:mainfrom
Conversation
Author
|
Will close this draft. Given the topic for this PR is solved by: The problem was fixed in this PR: huggingface/transformers#32617. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses a device mismatch issue in the
apply_rotary_pos_embfunction within the Qwen model implementation. Specifically, the cos and sin tensors, used for rope, were placed on the CPU, while other tensors (q, k, and position_ids) were on the GPU. This discrepancy caused a runtime error during training.The fix ensures that cos and sin are moved to the same device as position_ids, resolving the inconsistency and allowing the model to run successfully on the GPU.
Fixes (#32312)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.