Allow for nightly packages of compressed_tensors#33828
Merged
LysandreJik merged 2 commits intohuggingface:mainfrom Oct 2, 2024
Merged
Allow for nightly packages of compressed_tensors#33828LysandreJik merged 2 commits intohuggingface:mainfrom
compressed_tensors#33828LysandreJik merged 2 commits intohuggingface:mainfrom
Conversation
compressed_tensors-nightlycompressed_tensors
markurtz
approved these changes
Sep 30, 2024
markurtz
left a comment
There was a problem hiding this comment.
These changes look correct to me. It brings up a separate consideration that we'll need at some point in the future, which is to gather the compressed tensors version so we can compare if there are breaking changes between the config format that is stored with the model and the compressed tensors that is loaded, especially with it loading nightly dev builds
mgoin
reviewed
Sep 30, 2024
LysandreJik
approved these changes
Oct 2, 2024
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* only check spec * correct typo in nightly package name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR follows up on #31704 by allowing the
compressed-tensors-nightlypackage to be used to load compressed tensors modules. This is done by relaxing installation requirements to only require thecompressed-tensorsmodule spec, but not thecompressed-tensorspackage.Compressed Tensors models cannot be loaded with nightly package
Compressed Tensors is reported as unavailable, despite the module being available through the nightly package
After the changes, models can be imported with the nightly package and compressed tensors is reported as being available
Who can review?
@SunMarc @ArthurZucker
@dsikka @dhuangnm @andy-neuma
Anyone in the community is free to review the PR once the tests have passed.