Config: lower save_pretrained exception to warning#33906
Merged
gante merged 4 commits intohuggingface:mainfrom Oct 3, 2024
Merged
Config: lower save_pretrained exception to warning#33906gante merged 4 commits intohuggingface:mainfrom
save_pretrained exception to warning#33906gante merged 4 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
Thanks for the fix Joao! |
ArthurZucker
pushed a commit
that referenced
this pull request
Oct 7, 2024
* lower to warning * msg * make fixup * rm extra comma
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* lower to warning * msg * make fixup * rm extra comma
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Round 2, after #33886 -- TL;DR stops raising exceptions when saving a model config with generative parameters, if the user is not responsible for those parameters being there.
(copied from 33886)
33886 would be my intended solution to the problem, but I ran into multiple implementation issues which I'll iron out in separate PRs 👀 This PR is a poor man's version of the solution, to unblock others: simply lower the exception to a warning.
(cc @regisss )