check if eigenvalues of covariance matrix are complex. #34037
Merged
ArthurZucker merged 1 commit intohuggingface:mainfrom Oct 10, 2024
Merged
check if eigenvalues of covariance matrix are complex. #34037ArthurZucker merged 1 commit intohuggingface:mainfrom
ArthurZucker merged 1 commit intohuggingface:mainfrom
Conversation
gante
approved these changes
Oct 9, 2024
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
LGTM, thank you for having a look at that skip 💛
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
…4037) check if eigenvalues of covariance complex for psd checking
4 tasks
sandeep-maddipatla
added a commit
to sandeep-maddipatla/optimum-habana
that referenced
this pull request
Jan 30, 2025
…f Positive definiteness - huggingface/transformers#34037 introduces a check to verify the covariance matrix generated within the `PreTrainedModel::_init_added_embeddings_weights_with_mean` function. - This regresses tests on HPU functionally. - This is a temporary WA to move to the older version of the function, while a longer term fix for the problem is in the works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up for #33950 and #33325
This fixes reformer test_resize_tokens_embeddings. We should check if the eigenvalues are complex also to check if the covariance is positive definite.
c.c. @gante Thaks for the other fixes!
and c.c. @ArthurZucker