[Llama] Fix QnA loading from pretrained via loading hooks#34038
Closed
vasqu wants to merge 1 commit intohuggingface:mainfrom
Closed
[Llama] Fix QnA loading from pretrained via loading hooks#34038vasqu wants to merge 1 commit intohuggingface:mainfrom
Llama] Fix QnA loading from pretrained via loading hooks#34038vasqu wants to merge 1 commit intohuggingface:mainfrom
Conversation
Contributor
Author
|
Oops, might be not as great of a solution as I thought, I'll check later if I can fix the failing tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently,
LlamaForQuestionAnsweringis broken when we try to load from a pretrained ckpt, see #30381 for reference. In the same issue, a workaround has been suggested but I think this is too obscure and unintuitive. #29258 was supposed to fix general loading issues, but it hasn't. Due to BC reasons, I opted for loading hooks that imitate the base model prefix as in every otherForXXXclass and rename it after successfully loading the model. This way, people that already have the transformer prefix can use it as usual and loading from a pretrained ckpt will work as expected.Fixes #30381 (this time really :D)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ArthurZucker