Only cast logits to float when computing loss#34147
Merged
ArthurZucker merged 2 commits intohuggingface:mainfrom Oct 18, 2024
Merged
Only cast logits to float when computing loss#34147ArthurZucker merged 2 commits intohuggingface:mainfrom
ArthurZucker merged 2 commits intohuggingface:mainfrom
Conversation
Some misses from huggingface#31292 and huggingface#33902
gante
approved these changes
Oct 17, 2024
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
LGTM, thank you for the fix 🙏
ArthurZucker
approved these changes
Oct 18, 2024
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
🤗 thanks for bookeeping hehe
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
Oct 21, 2024
* Only cast logits to float when computing loss Some misses from huggingface#31292 and huggingface#33902 * Move logits.float() into existing if labels is not None branch
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* Only cast logits to float when computing loss Some misses from huggingface#31292 and huggingface#33902 * Move logits.float() into existing if labels is not None branch
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A few updates that were missed in #31292 and #33902.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
cc: @Cyrilvallez @gante @ArthurZucker