Fix continue_final_message for image-text-to-text chat templates#34236
Merged
yonigozlan merged 2 commits intohuggingface:mainfrom Oct 22, 2024
Merged
Fix continue_final_message for image-text-to-text chat templates#34236yonigozlan merged 2 commits intohuggingface:mainfrom
yonigozlan merged 2 commits intohuggingface:mainfrom
Conversation
zucchini-nlp
approved these changes
Oct 18, 2024
Member
zucchini-nlp
left a comment
There was a problem hiding this comment.
LGTM, thanks! Maybe also cc @Rocketknight1
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Cool! Can we have a small test please? 🤗
Member
Author
|
Added one test for llava processor :). I could add one for every vlms processor that use chat template, but as they all use the same underlying |
2fa12a4 to
64523c2
Compare
64523c2 to
afc298f
Compare
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
…gingface#34236) * fix continue_final_message for vlms * Add one test for vlms continue_final_message chat template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
contentfield for an image-text-to-text model is a list, which is not currently taken into account whencontinue_final_messageis set to True in tokenization_utils_base.Split from image-text-to-text PR
Reproduce error:
@zucchini-nlp @ArthurZucker