[CLIPSeg] Make interpolate_pos_encoding default to True#34419
Merged
NielsRogge merged 6 commits intohuggingface:mainfrom Oct 31, 2024
Merged
[CLIPSeg] Make interpolate_pos_encoding default to True#34419NielsRogge merged 6 commits intohuggingface:mainfrom
NielsRogge merged 6 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
Please see my comment #34415 (comment) before merging. |
NielsRogge
changed the title
Collaborator
Author
|
I've updated my PR description based on your comments |
ArthurZucker
approved these changes
Oct 30, 2024
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
LGTM thanks, not sure why one of the integration test is gone, congrats on getting the old logits back! 🥳
Collaborator
Author
|
I just reverted to the interpolation which is used by all other models, so the logits diff remains (edit: it looks like it has to do with my local setup) |
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
…34419) * Remove interpolate_pos_encoding * Make fixup * Make interpolate_pos_encoding default to True * Reuse existing interpolation * Add integration test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes #34415 by making
interpolate_pos_encodingdefault toTrue.