Skip to content

revert unpin isort commit#3449

Merged
julien-c merged 1 commit intohuggingface:masterfrom
patrickvonplaten:pin_isort
Mar 26, 2020
Merged

revert unpin isort commit#3449
julien-c merged 1 commit intohuggingface:masterfrom
patrickvonplaten:pin_isort

Conversation

@patrickvonplaten
Copy link
Copy Markdown
Contributor

This PR reverts the change of
fbc5bf1

Using the unpinned version of isort makes black and isort disagree in some cases.
In this PR the unpinned version of isort leads to a falied code quality test:
#3411

@julien-c julien-c requested review from julien-c and removed request for julien-c March 26, 2020 11:54
@julien-c
Copy link
Copy Markdown
Member

This syntax is not support by PyPi unfortunately, so we had to revert this.

@patrickvonplaten
Copy link
Copy Markdown
Contributor Author

This syntax is not support by PyPi unfortunately, so we had to revert this.

I see...is there another way of getting the pinned version?
In general, do we need isort? Doesn't black also sort the import statements?

@julien-c
Copy link
Copy Markdown
Member

Other ways are:

  • bug the isort maintainer to release a version containing this commit
  • push a new forked package to PyPI, like isort-pvp or isort-black-compat or whatever.

Yes we need isort.

@mgoldey
Copy link
Copy Markdown
Contributor

mgoldey commented Mar 26, 2020

I have also observed this issue with #3402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants