revert unpin isort commit#3449
Merged
julien-c merged 1 commit intohuggingface:masterfrom Mar 26, 2020
Merged
Conversation
Member
|
This syntax is not support by PyPi unfortunately, so we had to revert this. |
Contributor
Author
I see...is there another way of getting the pinned version? |
Member
|
Other ways are:
Yes we need isort. |
This was referenced Mar 26, 2020
Contributor
|
I have also observed this issue with #3402 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the change of
fbc5bf1
Using the unpinned version of
isortmakes black andisortdisagree in some cases.In this PR the unpinned version of
isortleads to a falied code quality test:#3411