[DO NOT MERGE] Add pytest-subtests to the dependencies#34753
Draft
dvrogozh wants to merge 1 commit intohuggingface:mainfrom
Draft
[DO NOT MERGE] Add pytest-subtests to the dependencies#34753dvrogozh wants to merge 1 commit intohuggingface:mainfrom
dvrogozh wants to merge 1 commit intohuggingface:mainfrom
Conversation
As discussed in [1], pytest-subtests changes behavior of .skipTest() having effect to really skip individual subtests or skip the entire test if module is not installed. Huggingface Accelerate has module in its dependencies. It makes sense to add it for Transformers as well to avoid divergent environment between users and ci. See[1]: huggingface#34723 (comment) Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
Contributor
Author
|
@ydshieh : I don't see that pytest-subtests propagated to circleci environment after I updated setup.py (it is not in the installed package list which circleci prints). Does circleci has different list of packages to install somewhere? or I did some mistake updating setup.py. |
Collaborator
|
Hi @dvrogozh . I think And I think it would be better to (for us) to figure out what happens before merging this PR. |
Collaborator
|
Let's wait pytest-dev/pytest-subtests#169 (without it, using pytest-subtests is not reliable in some cases) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pushing a draft PR to check that CI will start catching #34722. If it will, I suggest to update PR #34723 with this change.
As discussed in [1], pytest-subtests changes behavior of .skipTest() having effect to really skip individual subtests or skip the entire test if module is not installed. Huggingface Accelerate has module in its dependencies. It makes sense to add it for Transformers as well to avoid divergent environment between users and ci.
See[1]: #34723 (comment)
CC: @ydshieh