[peft] Given that self.active_adapter is deprecated, avoid using it#34804
Merged
ArthurZucker merged 2 commits intohuggingface:mainfrom Nov 25, 2024
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BenjaminBossan
approved these changes
Nov 19, 2024
Member
BenjaminBossan
left a comment
There was a problem hiding this comment.
Thanks for fixing this, LGTM.
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
…it (huggingface#34804) * Given that self.active_adapter is deprecated, avoid using it * Remove misleading comment - `self.active_adapter` is not used (and deprecated)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PeftAdapterMixin.active_adapterhas been deprecated since #26407 added multi-adapter support, but it's still being used inPeftAdapterMixin.get_adapter_state_dict. This results in a FutureWarning every time I save a checkpoint after training withmodel.add_adapter(...).This PR updates the latter to use the correct
PeftAdapterMixin.active_adapters()[0]method instead, which is identical in behaviour, except minus the warning.The deprecated
active_adapter:transformers/src/transformers/integrations/peft.py
Lines 433 to 438 in 54739a3
Additionally, the comment
in
enable_adaptersseemed to be a bit misleading - that method wasn't being used. For clarity, I removed it.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker @BenjaminBossan