Whisper: remove redundant assisted generation tests#34814
Merged
gante merged 6 commits intohuggingface:mainfrom Feb 12, 2025
Merged
Conversation
gante
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks a lot for the detailed explanation!
We need to keep the max length changes 🤗
4 tasks
Closed
4 tasks
Contributor
Author
|
(failures look related to other failures on |
Contributor
Author
|
@ArthurZucker @ydshieh ready for review :) (this PR now just removes deprecated features and tests -- see PR header) |
ydshieh
approved these changes
Jan 30, 2025
Collaborator
ydshieh
left a comment
ydshieh
left a comment
There was a problem hiding this comment.
LGTM (with things being explained the PR description), but better to have other maintainers to have a look.
ArthurZucker
approved these changes
Feb 4, 2025
gante
deleted the
fix_test_assisted_decoding_encoder_decoder_shared_encoder
branch
sbucaille
pushed a commit
to sbucaille/transformers
that referenced
this pull request
Feb 16, 2025
* remove redundant test * delete another test * revert default max_length * (wrong place, moving)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of making CI green in preparation for #34807 (test fetcher fetches generation tests)
Reverts recent defaultmax_length-related changes. The default max length is20and, due to recent changes, a different length was being returned in some cases. Whisper was one of the affected models, it was defaulting to a length of21.test_assisted_decoding_encoder_decoder_shared_encoder(integration test) -- the point of this test was to test assisted generation with DistilWhisper-like structure, which used to have a custom input (assistant_encoder_outputs). a) That input is no longer present in Whisper b) the DistilWhisper structure didn't take off, so it's overkill to have an abstract test with dummy classes c) we have other DistilWhisper tests.test_model_kwarg_assisted_decoding_encoder_decoder(integration test) -- added when DistiWhisper was added. Meanwhile, assisted generation was modified to work with any encoder-decoder model, and we have mixin tests.