adjust beam search early stopping to any criteria as opposed to all#35023
Open
secrettoad wants to merge 2 commits intohuggingface:mainfrom
Open
adjust beam search early stopping to any criteria as opposed to all#35023secrettoad wants to merge 2 commits intohuggingface:mainfrom
secrettoad wants to merge 2 commits intohuggingface:mainfrom
Conversation
Contributor
Author
|
I'll take a look at the failing tests |
Contributor
Author
|
PyTorch and Tensorflow equivalence test that failed on previous build seems to be non-deterministic, or at the least not reproducible or related to this change. Passing now |
Member
Member
|
For beam search I'd recommend to wait for gante as he had some plans for general refactoring, he'll be back later next week. |
Contributor
Author
|
@gante this seems like an easy fix to the bug mentioned. what do you think? |
Contributor
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #34843, adjusting the requirement to early stop during generation via beam search to ANY of the supplied criteria as opposed to ALL
Fixes #34843
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@Rocketknight1 @gante