Add type hints for forward functions in Gemma2#35034
Merged
Rocketknight1 merged 2 commits intohuggingface:mainfrom Dec 2, 2024
Merged
Add type hints for forward functions in Gemma2#35034Rocketknight1 merged 2 commits intohuggingface:mainfrom
Rocketknight1 merged 2 commits intohuggingface:mainfrom
Conversation
Rocketknight1
approved these changes
Dec 2, 2024
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
LGTM, and thank you for the PR!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* feat: add gemma2 type hints * fix: mask is optional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add type hints to functions added in #34282
Who can review?
@ArthurZucker