Skip to content

fix check for loss_kwargs/GA#35127

Closed
winglian wants to merge 1 commit intohuggingface:mainfrom
winglian:fix-num_items_in_batch-check
Closed

fix check for loss_kwargs/GA#35127
winglian wants to merge 1 commit intohuggingface:mainfrom
winglian:fix-num_items_in_batch-check

Conversation

@winglian
Copy link
Copy Markdown
Collaborator

@winglian winglian commented Dec 6, 2024

What does this PR do?

#34915 didn't quite do what was intended and seems to break packing. Since loss_kwargs was replaced with num_items_in_batch, we should probably be checking for that. This fixes tests on our end that runs a fine-tune with packing and validates the loss. Without this fix, the loss is ~3x larger than it should be with packing.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@winglian
Copy link
Copy Markdown
Collaborator Author

winglian commented Dec 6, 2024

I effed this one up

@winglian winglian closed this Dec 6, 2024
@winglian winglian deleted the fix-num_items_in_batch-check branch December 6, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant