Skip to content

Patch GPTNeoX to use adequate FA2 if position_ids is provided#35318

Merged
ArthurZucker merged 1 commit intohuggingface:mainfrom
taha-yassine:patch_fa2
Dec 23, 2024
Merged

Patch GPTNeoX to use adequate FA2 if position_ids is provided#35318
ArthurZucker merged 1 commit intohuggingface:mainfrom
taha-yassine:patch_fa2

Conversation

@taha-yassine
Copy link
Copy Markdown
Contributor

What does this PR do?

#31629 introduced the ability to use position_ids in FlashAttention-2, but not all models were updated to support it. This PR is a straightforward extension to GPT-NeoX models.

I was looking into including GPT-2 too, but from a quick glance at the code it seems a little bit trickier.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ArthurZucker

Copy link
Copy Markdown
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! 🤗

@ArthurZucker ArthurZucker merged commit 2bb6098 into huggingface:main Dec 23, 2024
@taha-yassine taha-yassine deleted the patch_fa2 branch December 1, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants