Fix: bamba error handling kwargs with forward pass #35378
Closed
Ssukriti wants to merge 2 commits intohuggingface:mainfrom
Closed
Fix: bamba error handling kwargs with forward pass #35378Ssukriti wants to merge 2 commits intohuggingface:mainfrom
Ssukriti wants to merge 2 commits intohuggingface:mainfrom
Conversation
Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com>
Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com>
Ssukriti
force-pushed
the
fix_bamba_error_forward_Trainer
branch
from
abe82db to
ffe384e
Compare
Contributor
|
@ArthurZucker @molbap this is just a temporary minor fix to make the model work with |
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
We can close this as #35875 added this! 🤗 sorry for the delay!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a small change to handle additional kwargs passed to the forward function of
BambaModelarchitecture.Fixes a behavior when tuning Bamba models - when HF Trainer would pass additional LossArgs to
BambaForCausalLM.forward(), which are passed toBambaModel.forward, and need to be ignored.This would fix the error -
num_items_in_batchis an unexpected arg , while tuning the model.Additional Context:
LlamaForCausalLM class passes all kwargs to self.model.forward , hence they need to be handled.
In the future, we would add support for flashAttentionKwargs in BambaModel.forward() .
cc: @fabianlim
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.