Merged
Conversation
ydshieh
force-pushed
the
fix_flaky_test_batching_equivalence
branch
from
223bfe2 to
39d3a35
Compare
Collaborator
Author
|
For context: see previous similar fixes #34995 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
commented
Jan 8, 2025
Comment on lines
+1423
to
+1424
| if hasattr(test_case.model_tester, "out_features") or hasattr(test_case.model_tester, "out_indices"): | ||
| target_num_hidden_layers = None |
Collaborator
Author
There was a problem hiding this comment.
some vision models is hard to adjust the number of layers as sometimes other parameters have to be changed at the same time
zucchini-nlp
approved these changes
Jan 9, 2025
Member
zucchini-nlp
left a comment
zucchini-nlp
left a comment
There was a problem hiding this comment.
Yay, less flaky tests! Thanks!
Collaborator
Author
|
There are some model test cases overwrite the common one with |
This was referenced Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I am the king serial killer of flaky tests in
transformers!The the ratio of failures:
tests/models/flaubert/test_modeling_flaubert.py::FlaubertModelTest::test_batching_equivalence:tests/models/mobilevitv2/test_modeling_mobilevitv2.py::MobileViTV2ModelTest::test_batching_equivalence:tests/models/xlm/test_modeling_xlm.py::XLMModelTest::test_batching_equivalence:I will apply the same changes to overwritten tests wherever they are flaky too.